Reset overflow counter on None onOverflow result #248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I know that according to the contribution guidelines I should've opened an issue, but this is just a short bugfix. I will be happy to do it in case you decide it's required here.
I believe that current behaviour of Drop*AndSignal wasn't intended and seems to have been introduced just recently. The docs state:
yet I've noticed that after an overflow the callback is called for each new message.
I've modified the tests to check for this behaviour and proposed a solution.