Reset overflow counter on None onOverflow result #248

Merged
merged 4 commits into from Oct 18, 2016

Projects

None yet

2 participants

@ddworak
Contributor
ddworak commented Oct 18, 2016 edited

Hey!
I know that according to the contribution guidelines I should've opened an issue, but this is just a short bugfix. I will be happy to do it in case you decide it's required here.
I believe that current behaviour of Drop*AndSignal wasn't intended and seems to have been introduced just recently. The docs state:

The function can return None in which case no message is sent and thus you can use it just to log a warning.

yet I've noticed that after an overflow the callback is called for each new message.
I've modified the tests to check for this behaviour and proposed a solution.

ddworak added some commits Oct 18, 2016
@ddworak ddworak Break Drop*AndSignal tests 096d23f
@ddworak ddworak Reset dropped events count after logging b4e3eeb
@ddworak ddworak Rename test for consistency a2f5a8b
@ddworak ddworak Add ddworak to AUTHORS
ad714d8
@alexandru
Member

Thanks a lot @ddworak, stupid bug, stupid test.

Thanks for catching and fixing it. Scala.js also has released a new version, I guess it is time for another minor release. After also fixing #247.

@alexandru alexandru merged commit c63e38d into monix:master Oct 18, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@alexandru
Member

@ddworak this is released in latest version 2.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment