Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset overflow counter on None onOverflow result #248

Merged
merged 4 commits into from Oct 18, 2016

Conversation

ddworak
Copy link
Contributor

@ddworak ddworak commented Oct 18, 2016

Hey!
I know that according to the contribution guidelines I should've opened an issue, but this is just a short bugfix. I will be happy to do it in case you decide it's required here.
I believe that current behaviour of Drop*AndSignal wasn't intended and seems to have been introduced just recently. The docs state:

The function can return None in which case no message is sent and thus you can use it just to log a warning.

yet I've noticed that after an overflow the callback is called for each new message.
I've modified the tests to check for this behaviour and proposed a solution.

@alexandru
Copy link
Member

Thanks a lot @ddworak, stupid bug, stupid test.

Thanks for catching and fixing it. Scala.js also has released a new version, I guess it is time for another minor release. After also fixing #247.

@alexandru alexandru merged commit c63e38d into monix:master Oct 18, 2016
@alexandru
Copy link
Member

@ddworak this is released in latest version 2.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants