Coeval and Task refactoring #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE - zipMap2, zipMap3...zipMap6 have been renamed: - in Coeval they've been renamed to map2, map3, ... map6 - in Task they've been renamed to parMap2, parMap3...parMap6, while map2, map3...map6 have been introduced Change breaks source compatibility.
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
========================================
+ Coverage 88.74% 89% +0.25%
========================================
Files 342 341 -1
Lines 9391 9400 +9
Branches 1278 1279 +1
========================================
+ Hits 8334 8366 +32
+ Misses 1057 1034 -23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coeval execution methods refactoring, we now have:
def run: Coeval.Eager[A]def runAttempt: Either[Throwable, A]def runTry: Try[A]For both
CoevalandTaskthezipMap2,zipMap3...zipMap6have been renamed:Coevalthey've been renamed tomap2,map3, ...map6Taskthey've been renamed toparMap2,parMap3...parMap6,while
map2,map3...map6have been introducedChange breaks source & binary compatibility.
Also added tests and ScalaDocs.