New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coeval and Task refactoring #430

Merged
merged 3 commits into from Sep 12, 2017

Conversation

Projects
None yet
1 participant
@alexandru
Member

alexandru commented Sep 12, 2017

Coeval execution methods refactoring, we now have:

  • def run: Coeval.Eager[A]
  • def runAttempt: Either[Throwable, A]
  • def runTry: Try[A]

For both Coeval and Task the zipMap2, zipMap3...zipMap6 have been renamed:

  • in Coeval they've been renamed to map2, map3, ... map6
  • in Task they've been renamed to parMap2, parMap3 ... parMap6,
    while map2, map3 ... map6 have been introduced

Change breaks source & binary compatibility.

Also added tests and ScalaDocs.

alexandru added some commits Sep 12, 2017

feat(eval): refactor Coeval and Task replacing zipMap2,zipMap3...
BREAKING CHANGE - zipMap2, zipMap3...zipMap6 have been renamed:

- in Coeval they've been renamed to map2, map3, ... map6
- in Task they've been renamed to parMap2, parMap3...parMap6,
  while map2, map3...map6 have been introduced

Change breaks source compatibility.
@codecov

This comment has been minimized.

codecov bot commented Sep 12, 2017

Codecov Report

Merging #430 into master will increase coverage by 0.25%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #430      +/-   ##
========================================
+ Coverage   88.74%    89%   +0.25%     
========================================
  Files         342    341       -1     
  Lines        9391   9400       +9     
  Branches     1278   1279       +1     
========================================
+ Hits         8334   8366      +32     
+ Misses       1057   1034      -23

@alexandru alexandru merged commit b6d70fb into monix:master Sep 12, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@alexandru alexandru added this to the 3.0.0 milestone Jan 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment