Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Current-Labs fork? #2

Open
incorvia opened this issue Oct 4, 2016 · 10 comments
Open

Merge Current-Labs fork? #2

incorvia opened this issue Oct 4, 2016 · 10 comments

Comments

@incorvia
Copy link

incorvia commented Oct 4, 2016

I've noticed that Current-labs forked your project and added support for generating customers and customer scoped access tokens. Are you in contact with them and if so have you thought of merging in their work? I was thinking of adding the functionality myself when I noticed it was already done to, though I haven't tested it. I could probably for his code, add some tests and attempt to bring it back into this project if that would interest you?

@zernyu
Copy link

zernyu commented Oct 4, 2016

Hello! I'm the one who forked the project. Sorry for the lack of tests... but we have been running the code successfully without any issue!

We use the Organizations API extensively, but as you'll notice in the commits, two methods (list_path and claim_path) are not supported. I don't remember why. Either they were breaking a test or they actually aren't supported in the Particle API, but we don't use those endpoints.

I hope my additions are clear enough and would save you time if you're looking to use the Organizations API as well! Feel free to add your own contributions and let me know if you have any questions. :)

Z

@monkbroc
Copy link
Owner

monkbroc commented Oct 4, 2016

I will be super glad to accept a pull request to include more customer endpoints into particlerb!

Let me know if either of you would like additional explanation on how the gem is organized and how the tests are set up.

@incorvia
Copy link
Author

incorvia commented Oct 4, 2016

I only today realized that there is a difference between managing customers
the organization API and through the product API, as evidenced by my question:

https://community.particle.io/t/whats-the-difference-between-org-vs-product-for-creating-customers/26295

I personally had wanted the product API. If this gets pulled I’ll see if there’s a way that I can
adjust for my needs.

On Tue, Oct 4, 2016 at 9:17 AM, Julien Vanier notifications@github.com
wrote:

I will be super glad to accept a pull request to include more customer
endpoints into particlerb!

Let me know if either of you would like additional explanation on how the
gem is organized and how the tests are set up.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXl9JEKhYjqvFc8GzUPYrAuaOng0KNTks5qwlHOgaJpZM4KNQtr
.

@zernyu
Copy link

zernyu commented Oct 4, 2016

Hehe yep... it's a bit confusing, isn't it?

@incorvia
Copy link
Author

incorvia commented Oct 4, 2016

@zernyu there seems to be no documentation on the web about the Organization API, what it is, and why you'd want to use it, do you have an insight?

@monkbroc
Copy link
Owner

monkbroc commented Oct 5, 2016

From what I understand the product routes are recommended. The organization routes are not yet deprecated, but could be soon. The docs are lacking in either case...

@zernyu
Copy link

zernyu commented Oct 5, 2016

That's absolutely bananas. It looks like they removed Organization routes from the docs completely. I never heard anything about it getting deprecated in favor of Products?

We use the Organization routes to create Customer accounts to claim their devices under, but it looks like now we'd have to create a Customer account once per Product?

@monkbroc
Copy link
Owner

monkbroc commented Oct 5, 2016

It might be best to open a ticket at support.particle.io and explain your use to check what is happening with organization routes.

@incorvia
Copy link
Author

incorvia commented Oct 5, 2016

I think in the long run, for this gem it'd be great to support products so that we can have a non-deprecated customer workflow. I'm imagining a product model that given a product has a product.create_customer(email) method on it.

@zernyu
Copy link

zernyu commented Dec 26, 2019

FYI Organizations endpoints were officially removed from the Particle API this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants