fix: correctly handling 404 errors when getting quotes

monkeytypegame · Feb 23, 2024 · 6db321c · 6db321c
1 parent d19a95e
commit 6db321c
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/frontend/src/ts/controllers/quotes-controller.ts b/frontend/src/ts/controllers/quotes-controller.ts
@@ -48,9 +48,18 @@ class QuotesController {
     const normalizedLanguage = removeLanguageSize(language);
 
     if (this.quoteCollection.language !== normalizedLanguage) {
-      const data = await cachedFetchJson<QuoteData>(
-        `quotes/${normalizedLanguage}.json`
-      );
+      let data: QuoteData;
+      try {
+        data = await cachedFetchJson<QuoteData>(
+          `quotes/${normalizedLanguage}.json`
+        );
+      } catch (e) {
+        if (e instanceof Error && e?.message?.includes("404")) {
+          return defaultQuoteCollection;
+        } else {
+          throw e;
+        }
+      }
 
       if (data.quotes === undefined || data.quotes.length === 0) {
         return defaultQuoteCollection;