fix: check if fields are not empty before sending request to the server

Closes #4643
monkeytypegame · Sep 18, 2023 · fe40988 · fe40988
1 parent 13aaf3a
commit fe40988
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/frontend/src/ts/popups/simple-popups.ts b/frontend/src/ts/popups/simple-popups.ts
@@ -433,7 +433,12 @@ list["updateName"] = new SimplePopup(
     try {
       const user = Auth?.currentUser;
       const snapshot = DB.getSnapshot();
-      if (!user || !snapshot) return;
+      if (!user || !snapshot) return true;
+
+      if (!pass || !newName) {
+        Notifications.add("Please fill in all fields", 0);
+        return false;
+      }
 
       if (user.providerData.find((p) => p?.providerId === "password")) {
         const credential = EmailAuthProvider.credential(