Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PT-BR #29

Closed
ubmit opened this issue May 17, 2020 · 6 comments
Closed

Add support for PT-BR #29

ubmit opened this issue May 17, 2020 · 6 comments
Labels
new feature A new, typically big, feature or idea

Comments

@ubmit
Copy link

ubmit commented May 17, 2020

I would like to help on adding support for Brazilian Portuguese. However, I took a look at the code and it seems that I'd need access to Firebase, right? Please, let me know if I can help!

@Miodec
Copy link
Member

Miodec commented May 17, 2020

As far as i can tell when developing locally firebase just starts a node server, so you could try that. (I will get do some research and set up a general “how to collaborate” guide some time soon)

But since adding languages is super simple, you could do it without even having to set up a local server. Just add another key to the words object in words.js file. Everything else should work

@ubmit
Copy link
Author

ubmit commented May 17, 2020

Oh, ok! I will do it and open a PR then! Thanks for the info @Miodec 🙌

@ubmit
Copy link
Author

ubmit commented May 17, 2020

Tried to run the project locally but I wasn't able to. Could you provide some info about the setup?

@Miodec Miodec added language new feature A new, typically big, feature or idea labels May 18, 2020
@Miodec
Copy link
Member

Miodec commented May 18, 2020

Okay so from what i learned if you want to run this project locally fully working with a database and stuff you need to create a new project on firebase on your google account, and then change the project name in .firebaserc. Make sure you install the firebase CLI and then firebase serve --only hosting to start a server. Let me know if you run into any issues

@ubmit
Copy link
Author

ubmit commented May 19, 2020

Ok, I will try this ASAP! Thanks!

@Miodec
Copy link
Member

Miodec commented Jun 5, 2020

34d0818

@Miodec Miodec closed this as completed Jun 5, 2020
Miodec pushed a commit that referenced this issue May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new, typically big, feature or idea
Projects
None yet
Development

No branches or pull requests

2 participants