Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure password managers work with the site #368

Closed
Miodec opened this issue Sep 23, 2020 · 10 comments
Closed

make sure password managers work with the site #368

Miodec opened this issue Sep 23, 2020 · 10 comments

Comments

@Miodec
Copy link
Member

Miodec commented Sep 23, 2020

No description provided.

@Miodec Miodec closed this as completed Sep 24, 2020
@greenbigfrog
Copy link

@Miodec this does not appear to be the case any more.
FFs built in did catch it, but bitwarden failed.
(also, the sign up form was not cleared after signing up. The content was still there)

@Miodec
Copy link
Member Author

Miodec commented Oct 11, 2021

What do you mean 'catch it but bitwarden failed'

@greenbigfrog
Copy link

The built in password manager in FF popped up asking if I want to save the login, but bitwarden did not.

@krmbzds
Copy link

krmbzds commented Jan 8, 2022

I cannot make auto-fill work with Bitwarden.
It fills up the registration form and leaves the login form empty.

@krmbzds
Copy link

krmbzds commented Jan 8, 2022

@Miodec, please check this resource to make it compatible with password managers.

Quoting the relevant section:

Use autocomplete="current-password" and id="current-password" for the password input in a sign-in form, or the input for the user's old password in a change-password form. This tells the browser that you want it to use the current password that it has stored for the site.
For a sign-up form:

<input type="password" autocomplete="new-password" id="new-password" >

For sign-in:

<input type="password" autocomplete="current-password" id="current-password" >

@Miodec
Copy link
Member Author

Miodec commented Jan 8, 2022

Followed the rules, pushed an update. Check now.

@Miodec Miodec reopened this Jan 8, 2022
@krmbzds
Copy link

krmbzds commented Jan 8, 2022

I checked the forms and they conform with the conventions, great! Bitwarden still fails to auto-fill the login form so I filed an auto-fill failure report. I guess it's on Bitwarden now. Either way, I think this was productive, thanks for the quick fix. 🙂

@whoibrar
Copy link

Thanks for opening an issue, I was so confused as to where the issue was!

@Miodec Miodec closed this as completed Jan 30, 2022
@ghost
Copy link

ghost commented Jul 16, 2022

@Miodec, please check this resource to make it compatible with password managers.

Quoting the relevant section:

Use autocomplete="current-password" and id="current-password" for the password input in a sign-in form, or the input for the user's old password in a change-password form. This tells the browser that you want it to use the current password that it has stored for the site.
For a sign-up form:

<input type="password" autocomplete="new-password" id="new-password" …>

For sign-in:

<input type="password" autocomplete="current-password" id="current-password" …>

I don't understand any of this mate. How exactly can I fix bitwarden autofill issue? Can you explain step by step ?

@krmbzds
Copy link

krmbzds commented Jul 17, 2022

@pc00per Bitwarden has to fix their own broken autofill mechanism -- nothing you can do at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants