Custom text saved with pipe delimiter isnt loaded correctly

[monkeytypegeorge]

No description provided.

[sanidhyas3s]

More details about the issue and steps to replicate would be helpful. I would like to work on this.
@Miodec

[Miodec]

If you enable pipe delimiter, then save the text this is|a test as custom text, when you load that text, it is incorrectly loaded as this|is|a|test

[sanidhyas3s]

If you enable pipe delimiter, then save the text this is|a test as custom text, when you load that text, it is incorrectly loaded as this|is|a|test

Can't seem to find the settings corresponding to this, where can I find it under.

[Miodec]

Test page > custom mode > change (this opens the custom text popup)

[sanidhyas3s]

The way it works right now, is that when saving it breaks the text into 'space' separated words, and then joins them with the delimiter (| if pipe is enabled, space otherwise). Do we want to replace space with | at all? Because when saving | is considered as any other character.

Current Behavior:
"This is|a test" --save with or without pipe delimiter on--> "This", "is|a", "test" --load with delimiter--> "This|is|a|test"

Possible Fix Behavior
"This is|a test" --save with or without pipe delimiter on--> "This", "is|a", "test" --load with delimiter--> "This is|a test"

but it will create situations like this as well:
"This is a test" --save with or without pipe delimiter on--> "This", "is", "a", "test" --load with delimiter--> "This is a test"

So, if the expected correct behavior is simply keeping spaces, spaces and not replacing them with |, basically if you want to load a pipe-delimited text, you must also save a pipe-delimited text. If this is what is needed then this is just a simple fix, I will make a MR with that done. The fix will solve this particular problem but will takeaway "space being replaced with pipe automatically", so its a choice between the two, as there's no mid-way solution to this. @Miodec

This is more of a UX question at this point, I have never used the pipe-delimiter, so can't comment.

[flyingRa1jin]

@sanidhyas3s this looks pretty much like the expected behaviour. @Miodec Why would you want to use Pipe character when you are going to use it as a delimiter?

[Miodec]

@Miodec Why would you want to use Pipe character when you are going to use it as a delimiter?

Dont understand the question sorry

[Miodec]

The way it works right now, is that when saving it breaks the text into 'space' separated words, and then joins them with the delimiter (| if pipe is enabled, space otherwise). Do we want to replace space with | at all? Because when saving | is considered as any other character.

Current Behavior: "This is|a test" --save with or without pipe delimiter on--> "This", "is|a", "test" --load with delimiter--> "This|is|a|test"

Possible Fix Behavior "This is|a test" --save with or without pipe delimiter on--> "This", "is|a", "test" --load with delimiter--> "This is|a test"

but it will create situations like this as well: "This is a test" --save with or without pipe delimiter on--> "This", "is", "a", "test" --load with delimiter--> "This is a test"

So, if the expected correct behavior is simply keeping spaces, spaces and not replacing them with |, basically if you want to load a pipe-delimited text, you must also save a pipe-delimited text. If this is what is needed then this is just a simple fix, I will make a MR with that done. The fix will solve this particular problem but will takeaway "space being replaced with pipe automatically", so its a choice between the two, as there's no mid-way solution to this. @Miodec

This is more of a UX question at this point, I have never used the pipe-delimiter, so can't comment.

My bad looks like i missed this or forgot to respond. I think removing the automatic space to pipe conversion to correct the loading is a fair tradeoff.

[sanidhyas3s]

@Miodec So, for a text saved without pipe delimiter wouldn't have pipe delimiters when loaded with pipe delimiter on, does that seem correct?

If yes, then simply we'll still break down the text based on space, and save it (text with pipe delimiter would just be saved as one long word) and then just combine them with space itself (this would be the only change).

[sanidhyas3s]

I have made a PR with the fix as proposed in the previous message, you can test it, and merge it if the behavior matches the expected behavior.