feat: Add Korean language quotes #4637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkeytypegeorge
added
frontend
plumpdolphin
changed the title
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/6205377224 |
Resolved improper length values on some quotes
|
Could you provide translations so i can verify the quote content? |
Miodec
added
the
waiting for update
|
Absolutely! I wasn't sure the best format to translate them, so I just dropped them into a text file side-by-side with the Korean quotes. Note that some of the books and TV series have official English translations, these are just my personal translations and are only intended to capture the message of the quotes to a certain degree of accuracy. I also translated the names of the sources, substituting in official translation/titles of TV shows and songs where applicable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds 25 initial Korean quotes to the existing language group. There are a combination of proverbs, TV quotes, book quotes, and some song lyrics.
I also modified the group length to be half of standard, as each Hangul character requires a minimum of two keystrokes, up to four.
This is just to get the ball rolling and provide initial content for others to build upon. If you have any questions or requests to help with merging, let me know and I'd be happy to oblige!