Split misc.ts into smaller util files #5187
Assignees
Comments
|
On it! |
sanidhyas3s
added a commit
to sanidhyas3s/monkeytype
that referenced
this issue
Mar 10, 2024
also renamed some functions for clarity for monkeytypegame#5187
|
Oh, this is gonna take some time. I have mostly separated the functions out into different categories (strings, date and time, numbers etc.), but refactoring where they are used and the corresponding imports would take a good amount of labor. Will try to get it done in the next few days anyways! |
sanidhyas3s
added a commit
to sanidhyas3s/monkeytype
that referenced
this issue
Mar 11, 2024
sanidhyas3s
added a commit
to sanidhyas3s/monkeytype
that referenced
this issue
Mar 11, 2024
sanidhyas3s
added a commit
to sanidhyas3s/monkeytype
that referenced
this issue
Mar 11, 2024
sanidhyas3s
added a commit
to sanidhyas3s/monkeytype
that referenced
this issue
Mar 11, 2024
add docstring to the functions in `utils/numbers` also, move `getDiscordAvatarUrl` back into misc because it was causing mt to not open somehow for monkeytypegame#5187
|
Update: still working on this, wasn't able to find much time this weekend, hence no updates, will get back and add more commits asap. |
sanidhyas3s
added a commit
to sanidhyas3s/monkeytype
that referenced
this issue
Mar 25, 2024
…d docstring for them
for monkeytypegame#5187
sanidhyas3s
added a commit
to sanidhyas3s/monkeytype
that referenced
this issue
Mar 25, 2024
… & add docstrings
for monkeytypegame#5187
Miodec
added a commit
that referenced
this issue
Apr 3, 2024
…f functions into separate util files from misc.ts (sanidhyas3s) (#5254) * fix: Prevent theme switch when opening theme commandline from the footer fixes #5103 * refactor(utils/misc): move functions and adjust usages also renamed some functions for clarity for #5187 * refactor(utils/misc): move color utils into separate file & add docstring for #5187 * refactor(utils/misc): separte out number-related utils and more add docstring to the functions in `utils/numbers` also, move `getDiscordAvatarUrl` back into misc because it was causing mt to not open somehow for #5187 * refactor(utils/misc): move get-text functions into separate file & add docstring for them for #5187 * refactor(utils/misc): move get-data type functions into separate file & add docstrings for #5187 * Fix cyclic dependency by moving function * Move strings utils to separate file and other minor changes to utils * Shift Date & Time util functions to a separate file and add docstrings * Shift more string functions to string util file * separate out Arrays functions from misc utils * Rename some utility files and move some functions * lowercase filename * rename module imports * move ddr stuff into its own file * temp file rename * file rename --------- Co-authored-by: Miodec <jack@monkeytype.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: