Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(utils): distribute color, numbers, strings and other group of functions into separate util files from misc.ts (sanidhyas3s) #5254

Merged
merged 20 commits into from Apr 3, 2024
Merged

refactor(utils): distribute color, numbers, strings and other group of functions into separate util files from misc.ts (sanidhyas3s) #5254

merged 20 commits into from Apr 3, 2024

Conversation

sanidhyas3s
Copy link
Contributor

@sanidhyas3s sanidhyas3s commented Mar 25, 2024 •
edited

Description

Big ol' refactoring

  • Divide functions for color, numbers, strings, arrays and more from misc.ts
  • add doc-strings for all these functions
  • refactor wherever these functions were being used

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

Closes #5187 (Not yet)

@sanidhyas3s
fix: Prevent theme switch when opening theme commandline from the footer
deb5bbe 
fixes monkeytypegame#5103
@sanidhyas3s
Merge branch 'master' of https://github.com/sanidhyas3s/monkeytype
2f5d3bf
@sanidhyas3s
refactor(utils/misc): move functions and adjust usages
97b6ee2 
also renamed some functions for clarity
for monkeytypegame#5187
@sanidhyas3s
refactor(utils/misc): move color utils into separate file & add docst…
519690e 
…ring

for monkeytypegame#5187
@sanidhyas3s
refactor(utils/misc): separte out number-related utils and more
13b23af 
add docstring to the functions in `utils/numbers`
also, move `getDiscordAvatarUrl` back into misc
because it was causing mt to not open somehow
for monkeytypegame#5187
@sanidhyas3s
refactor(utils/misc): move get-text functions into separate file & ad…
ba7b87f 
…d docstring for them

    for monkeytypegame#5187
@sanidhyas3s
refactor(utils/misc): move get-data type functions into separate file…
0c4c3ad 
… & add docstrings

    for monkeytypegame#5187
@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Mar 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label Apr 1, 2024
@Miodec
Copy link
Member

Miodec commented Apr 2, 2024

Could you have a look at the merge conflicts please?

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Apr 2, 2024
@sanidhyas3s
Copy link
Contributor Author

Could you have a look at the merge conflicts please?

Sure, on it!

@sanidhyas3s
Copy link
Contributor Author

@Miodec Done I guess, was mostly new uses of functions I shifted and some files being deleted in which I refactored for the shifted functions.

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8527459287

@github-actions github-actions bot removed the Stale Has not been updated in a while label Apr 2, 2024
Miodec
Miodec requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good so far, just a few minor tweaks.

frontend/src/ts/elements/profile.ts Outdated Show resolved Hide resolved
frontend/src/ts/utils/numbers.ts Outdated Show resolved Hide resolved
frontend/src/ts/utils/misc.ts Outdated Show resolved Hide resolved
frontend/src/ts/utils/misc.ts Outdated Show resolved Hide resolved
frontend/src/ts/utils/get-text.ts Outdated Show resolved Hide resolved
frontend/src/ts/utils/get-data.ts Outdated Show resolved Hide resolved
@sanidhyas3s
Copy link
Contributor Author

Good so far, just a few minor tweaks.

Great, will check the reviews after a couple of hours, once I am free from classes

@sanidhyas3s sanidhyas3s changed the title refactor(utils): distribute color, numbers, get-data and get-text type functions into separate util files from misc.ts (sanidhyas3s) refactor(utils): distribute color, numbers, strings and other group of functions into separate util files from misc.ts (sanidhyas3s) Apr 3, 2024
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8544395331

1 similar comment
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8544395331

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8544533690

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8544569070

@Miodec Miodec merged commit 39e611d into monkeytypegame:master Apr 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miodec Miodec Miodec approved these changes

Assignees
No one assigned
Labels
frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split misc.ts into smaller util files
3 participants
@sanidhyas3s @Miodec @monkeytypegeorge