style: Change csv file name when saving data (vjgtigers) #5248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer changing the delimiter. Google docs and Excel do not support LibreOffice and Google Docs don't support |
|
What if we change the main delimiter to be a "," and change the delimiter for "item.charStats" and "item.tags" to be something like "|" or ";". This way we keep the csv file extension and should be readable by most csv readers. |
|
Is this PR still needed if we change the delimiter to be a comma? |
Miodec
added
the
waiting for update
|
Closing as mentioned by the author in a different pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when downloading history it saves as a csv file but the data is not separated by commas. while most csv viewers can still read it, it could cause a little bit of confusion. This pull request changes the file extension to dsv (delimiter separated values) and changed "Export CSV" to "Export History". However changing "item.charStats" and "item.tags" to be joined by a different delimiter and changing the main delimiter to commas would also work and could keep the csv extension.