Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: custom text modal rework #5278

Merged
merged 26 commits into from
Apr 5, 2024
Merged

refactor: custom text modal rework #5278

merged 26 commits into from
Apr 5, 2024

Conversation

Miodec
Copy link
Member

@Miodec Miodec commented Apr 3, 2024

Completely rework the custom text modal.

  • use new modal system
  • rework the same (some) state is handled
  • slight styling updates

This PR also:

  • adds data passthrough option to animated modals
  • reworks save custom text and saved texts modals to use new modal system
  • fixes word filter popup being broken

Miodec added 25 commits April 2, 2024 23:23
@Miodec
start work on saved texts popup
adf13bc
@Miodec
passing options through, async fill to not block animation
1abaaab
@Miodec
handle apply
7a176ea
@Miodec
custom text modal start
a8c0d09
@Miodec
full save custom text modal refactor
167e6b8
@Miodec
remove import
eeef0a6
@Miodec
full finish on saved texts modal
3ea9616
@Miodec
fill when chain re-shows it
8465ec0
@Miodec
fix issues where opening chains within chains would show two modals
a216f0b
@Miodec
extract type
b3eb8f3
@Miodec
add support for passing data between modals
485c814
@Miodec
dont leave the popup if no words were found
096ee87
@Miodec
use modalchaindata instead of setting popup state directly
8f24365
@Miodec
handling set and append modes in chain data
7afbd09
@Miodec
move tab insertion code into the custom text modal file
56d1eed
@Miodec
use chain data instead of state module
593966a
@Miodec
move event handlers to a different file / to the setup function
7d9013a
@Miodec
move file
8892a4a
@Miodec
rename file
3febf65
@Miodec
rename id
1367427
@Miodec
remove unused line
9c77b83
@Miodec
add generics to incoming and outgoing modal chain data
cc77229
@Miodec
rework the way custom text textarea is handled
f88f870
@Miodec
update long custom text warning
e4d74ef
@Miodec
remove variable
c0ad507
@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Apr 3, 2024
@Miodec Miodec merged commit ff7816a into master Apr 5, 2024
7 checks passed
@Miodec Miodec deleted the custom-text-modal branch April 5, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
frontend User interface or web stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Miodec @monkeytypegeorge