Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): Add lilac_mist (sandyg6) #5415

Merged
merged 15 commits into from
Jun 10, 2024
Merged

Conversation

sandyg6
Copy link
Contributor

@sandyg6 sandyg6 commented May 17, 2024

Description

  • Added a new color palette feature to themes.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

Screenshot (117)

Screenshot (118)

Closes #

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels May 17, 2024
@Miodec
Copy link
Member

Miodec commented May 20, 2024

Text must be white or black (can be tinted). Please update.

@sandyg6
Copy link
Contributor Author

sandyg6 commented May 20, 2024

DESCRIPTION:

  • Updated new colors to the theme lilac_mist

image
image

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label May 23, 2024
Copy link
Contributor

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label May 31, 2024
@github-actions github-actions bot removed the Stale Has not been updated in a while label Jun 1, 2024
@Miodec
Copy link
Member

Miodec commented Jun 3, 2024

Switch the sub and text color around, and also diffrentiate somehow between (new) sub and main. That way text color will be darker.

@sandyg6
Copy link
Contributor Author

sandyg6 commented Jun 4, 2024

DESCRIPTION:

Updated new colors to the theme lilac_mist

Screenshot 2024-06-04 091710
Screenshot 2024-06-04 091728

@Miodec
Copy link
Member

Miodec commented Jun 4, 2024

image

Errors have 0 contrast compared to typed text.

@sandyg6
Copy link
Contributor Author

sandyg6 commented Jun 7, 2024

Description:

  • Newly updated error color
    Screenshot 2024-06-07 193537

darker text
pinker main
lighter sub
@Miodec Miodec merged commit 76eb104 into monkeytypegame:master Jun 10, 2024
6 checks passed
@Miodec
Copy link
Member

Miodec commented Jun 10, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants