Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr: optimize use of fontawesome (fehmer) #5423

Merged
merged 22 commits into from
Jun 7, 2024

Conversation

fehmer
Copy link
Member

@fehmer fehmer commented May 20, 2024

Reduces the size of fontawesome by approx 90%.

current sizes

file size
fa.min.css 13.2 kB
fa-solid-900.woff2 79.9 kB
fa-brands-400.woff2 77.2 kB
total 170.3 kB

optimized sizes

fontawesome 6

file size
fa.min.css 2.6 kb
fa-solid-900.woff2 13.1 kB
fa-brands-400.woff2 1.6 kB
total 17.3 kB

fontawesome 5

file size
fa.min.css 12.3 kb
fa-solid-900.woff2 11.5 kB
fa-brands-400.woff2 1.4 kB
total 25,2 kB

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels May 20, 2024
@fehmer fehmer force-pushed the feature/optimize-font-awesome branch from 7f9cc15 to 65aec6b Compare May 21, 2024 10:23
@fehmer fehmer marked this pull request as ready for review May 21, 2024 12:37
@fehmer fehmer changed the title impr: optimize size of fontawesome (fehmer) impr: optimize use of fontawesome (fehmer) May 21, 2024
@fehmer fehmer marked this pull request as draft May 21, 2024 15:25
@fehmer fehmer marked this pull request as ready for review May 23, 2024 14:37
Copy link
Contributor

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label May 30, 2024
@fehmer fehmer force-pushed the feature/optimize-font-awesome branch from b8cba96 to 4258054 Compare June 3, 2024 16:48
@github-actions github-actions bot removed the Stale Has not been updated in a while label Jun 3, 2024
frontend/vite.config.js Outdated Show resolved Hide resolved
@fehmer fehmer force-pushed the feature/optimize-font-awesome branch from ad6c83a to 20aa5a4 Compare June 4, 2024 11:47
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/9380179897

@fehmer fehmer force-pushed the feature/optimize-font-awesome branch from 89df692 to cafb930 Compare June 5, 2024 08:25
@Miodec Miodec merged commit fad3f6e into master Jun 7, 2024
7 checks passed
@Miodec Miodec deleted the feature/optimize-font-awesome branch June 7, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants