Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr(quotes): Correct typos and added quotes (faq0) #5465

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

faq0
Copy link
Contributor

@faq0 faq0 commented May 31, 2024

Description

Corrected 2 typos,
added some quotes in Simplified Chinese,
edited the length group.

Quotes added:

  1. 燕子去了,有再来的时候;杨柳枯了,有再青的时候;桃花谢了,有再开的时候。但是,聪明的,你告诉我,我们的日子为什么一去不复返呢?
    Translation: When the swallows go, there is a time to come again; when the willows are withered, there is a time to be green again; when the peach blossoms are shed, there is a time to bloom again. But, wise one, tell me, why do our days never return?
  2. 横眉冷对千夫指,俯首甘为孺子牛。
    Translation: Fierce-browed, I coolly defy a thousand pointing fingers; headbowed, like a willing ox I serve the children.
  3. 时间就像海绵里的水,只要愿挤,总还是有的。
    Translation: Time is like water in a sponge, as long as you are willing to squeeze, there is always time.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

Closes #

Corrected 2 typos,
added some quotes,
edited the length group.
@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels May 31, 2024
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/9317008633

edited one length of a quote
@extoplasm
Copy link
Contributor

yea sorry about that, the linux chinese input tool is a bit weird

@Miodec Miodec merged commit eac0f7c into monkeytypegame:master Jun 3, 2024
7 checks passed
@Miodec
Copy link
Member

Miodec commented Jun 3, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants