-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code color bug #70
Comments
Can't reproduce it. This must be some mess with machine endianness. |
I use Win7 x64 - Spanish version - UTF-8 |
I am having same problem on OSX Mavericks and ST3. I LOVE the idea of this new color picker you added right click context menu... However, if "Choose Color" opens the color picker with a different color than my selected color code, then I can't use it. |
Ok, i'll dig into it. |
Awesome thx :) |
@JerseyMilker Check out new version, please. I can't be sure, that the bug is fixed, haven't got the machine to test. |
Nothing, the new version dont fix the problem. |
@LOQUILLO, Can you please test this binary https://www.dropbox.com/s/x3xmsgalvgkv67t/ColorPicker_win.exe? It should print additional information to sublime console. I could use that info. |
It fix the correct color bug. But ""highlight_all": true" isn't working, yet. |
here is console log: Parsed input: 52 82 111 255 Initial: 6F5234 Traceback (most recent call last): |
here is other log: Parsed input: 52 82 111 255 Initial: 6F5234 Traceback (most recent call last): |
The first log is when I had select/pick color, the second log is when had selected/picked color and select "Choose color" and loaded Color Picker. |
Wait a second, this binary is the same as in master branch, only prints of debug info are added! It just can't fix a color problem! |
Which color did you select with last log? I need exact text. |
Weird, since updating, I can't even open the Choose Color picker now; whether by |
#34526f for boths logs |
hi @JerseyMilker patiente, patiente, this will be fixed soon. |
That's fair, thank you sirs :D |
@JerseyMilker Yeah, sorry, it was a typo i missed. Fixed now. |
@LOQUILLO What color do you select to cause the bug with |
#34526f for boths logs |
this is the code #34526f for boths logs, but is the same for any #xxxxxx code. |
This is the console log for #69 (069) code color: |
I had selected/picked '#69' (069) code color and select "Choose color" and loaded Color Picker. |
Wait, wait, wait, I see that versión of ColorHighlighter.py (on my machine) is 6.0.0 |
Hey, not sure if this is relevant to this issue you guys are working on or not... When I open "Choose Color" to edit a color code, the picker opens fine. But if I click "Cancel" in the picker itself, the currently selected color code gets changed to #000000. If "Cancel" is clicked, it should not modify any of my code, right? |
This is the new concole log with ColorHighlighter.py 6.0.2: |
Hi @JerseyMilker your is a bug for Mac version only; it was a bug for Windows versión too, but was fixed. Maybe if you is testing could helpus for solve this issue. I think that it's the Mac ColorPicker need fix this issue. |
Hi @JerseyMilker maybe the ColorHighlighter in your machine need an update, or delete completly and install again, you will get the new files updated. |
The thing is i have no mac to rebuild the code for it, sorry :( |
@LOQUILLO I dont beleve its #34526f. |
Okay. It seems it's completely broken on OSX still. If you can't rebuild the Mac stuff, I am not sure if I am very knowledgable to help :( Are you saying this is an Apple issue, meaning that they need to update their Color Picker? Or is this just a matter of someone building an updated ColorPicker_osx_x64 binary to include with Color Highlighter? If the latter, I can look into building and testing the binary on OSX. |
@JerseyMilker Yes, i just need to rebuild the ColorPicker_osx_x64 binary file, but i have no mac to do such. |
Well I have a bit of experience with building and linking C++ against SFML libs... though I did that in Windows with CMake and Visual Studio. I've never built binaries on mac or used XCode. I am primarily a web dev :( I'd be willing to try though if you can't find anyone. And if that's the case, is the Qt lib a free download? As for my problems, yes if you look at my above comment (above the last log paste), I have problem with pressing the "Cancel" button in the OSX Color Picker. Pressing cancel ends up changing the selected color code to #000000. |
This problem has also been fixed, and it will work as soon as someone helps me with building the ColorPicker/qt project for mac. |
Can I use CMake? I am downloading now... Though, looking at your repo structure, I would need guidance what source to build, and where to get Qt for linking, etc. |
hi @Monnoroch this is the css file: |
@LOQUILLO, Thanks very much, i finally fixed your problem! |
When I select code color something like #xxxxxx and "Choose color" then display other color:
![bug v5 0](https://cloud.githubusercontent.com/assets/1308190/2655445/36f15542-bfe6-11e3-8794-7fc3af13b005.jpg)
![bug ok v5 0](https://cloud.githubusercontent.com/assets/1308190/2655452/589699e6-bfe6-11e3-90b5-9b7faf74466d.jpg)
When I select code color something like #xxx and "Choose color" then display the correct color:
The text was updated successfully, but these errors were encountered: