Structible classes #501
Closed
Structible classes #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a function in Clang we do not use yet that can give you that information. Please add a new property Class.IsStruct and then fill its value by using clang::RecordDecl::isStruct() in Parser::WalkRecord. Make it work this way for the time being. Then we'll think about whether to use both that and IsValueType or stick to just one. |
|
@ddobrev Thanks. Will look into the clang docs. Also, will try to implement
it this way.
|
|
Closing this since changing the way of implementation... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess everything else is fine. I just couldn't find how to check if a class has been defined by 'class' keyword or 'struct'!! Please review and help. @ddobrev @tritao