[android] ResourceDesignerGenerator still needs to fail out

mono · Jul 5, 2017 · f6641f2 · f6641f2
1 parent e44af31
commit f6641f2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/binder/Utils/ResourceDesignerGenerator.cs b/binder/Utils/ResourceDesignerGenerator.cs
@@ -179,14 +179,15 @@ public bool WriteAssembly()
             return true;
         }
 
-        public void WriteSource()
+        public string WriteSource()
         {
             string resourcePath = Path.Combine(OutputDirectory, "Resource.designer.cs");
             using (var stream = File.Create(resourcePath))
             using (var writer = new StreamWriter(stream))
             {
                 csc.GenerateCodeFromCompileUnit(unit, writer, options);
             }
+            return resourcePath;
         }
 
         public string ToSource()

diff --git a/binder/Utils/XamarinAndroidBuild.cs b/binder/Utils/XamarinAndroidBuild.cs
@@ -83,7 +83,8 @@ public static string GeneratePackageProject(List<IKVM.Reflection.Assembly> assem
             if (!resourceDesigner.WriteAssembly())
             {
                 //Let's generate CS if this failed
-                resourceDesigner.WriteSource();
+                string resourcePath = resourceDesigner.WriteSource();
+                throw new Exception($"Resource.designer.dll compilation failed! See {resourcePath} for details.");
             }
 
             //ResolveAssemblies Task