HarfBuzz update #766
HarfBuzz update #766
Conversation
|
You don't seem to use xml comments how do I add documentation for added features? |
|
For docs, we run a task and then that will generate the files in the docs folder. Then we hand edit. The docs task is a fairly complex process and requires that all platforms be built and present - it then processes all the assemblies at once and generates the correct API docs, diffs and other variations. I wouldn't worry about that at the moment as I usually run it periodically. If you really need to generate docs, then just let me know. |
|
whitelist |
|
Looking at the project file changes and wondering why Microsoft doesn't support wildcards everywhere... Then we are going to get to all those xcode projects :) |
|
Thats fine for me. We can add documentation later when this is finished feature wise. |
|
I added you to the whitelist, so you should be able to see results as you go along. One thing that you may want to change is the fact that if one build fails, it cancels all the others. Since you probably are going to work one platform at a time, you may want to flip this switch: https://github.com/mono/SkiaSharp/blob/master/scripts/pipeline.groovy#L71 That will allow CI to build what it can, and then stop at the end of the process. If there are any platforms that you can't build for some reason, let me know and I can either help you set up, or make the changes - so you don't have to spend all your time tinkering with some obscure platform SDK. |
|
Will fix all non-apple platforms first on a virtual machine. And will then commit everything to reduce noise. Someone with XCode needs to update all related files. The XCode file format is just too much of a pain to edit it by hand. Linux and Windows build should now work. On Linux, I had to add some required packages to the build task. Will re-enable fastFail again to also reduce noise. I just learned I should keep my commits to a minimum. |
|
It's those darn docs tooling - "we're gonna build", "we're building", "were done building!" Massive. Comment. Needed. lol |
Add Face Tables
… into harfbuzzUpdate
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
- converted default arguments into overloads
- fixed a few whitespaces in unchanged files
- updated all the projects to C# 7.3
- the Buffer propertes are now arrays again, but added methods for the spans
- reduce breaking changes
- the values can be broken if the buffer changes, so use a better named method
- removed the new Point type
- don't want to add another point type to the world
- will use the .net standard 2.0 Point type when we upgrade
- the Font.Scale property is removed for now, but we will add it back with the drawing point type
- the Font GetAdvances are now returning arrays
- the spans were not necessary as the type is an explicit array
- changed the casing of the various script properties
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This is the initial work to bring HarfBuzz to the current version and making it easier to update in the future. The library will no longer be downloaded as a zip file and instead was added as a submodule to the repository. The build process is almost the same and just the download part is removed.
HarfBuzz itself is no on the current release version 2.3.1
HarfBuzzSharp got some substantial additions but also has some breaking signature changes. The goal was to support more of the API and make it easier to integrate HarfBuzz into an existing application.