Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS requires that the view have a background #1730

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Conversation

mattleibow
Copy link
Contributor

Description of Change

If there is no color set, then iOS can't clear it. As a result, the canvas is clear, but then it draws that clear canvas onto whatever there was before. And what was there before was the canvas so it keeps stacking things up.

This PR make sure that we let iOS know that it has to clear the underlying surface with transparent.

Bugs Fixed

An issue where the canvas never really cleared.

API Changes

None.

Behavioral Changes

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation

If there is no color set, then iOS can't clear it. As a result, the canvas is clear, but then it draws that clear canvas onto whatever there was before.
@mattleibow mattleibow merged commit 5fb7bc7 into develop Jul 6, 2021
@mattleibow mattleibow deleted the dev/clear-surface branch July 6, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant