Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wasm): Add mt and mt+simd, fix harfbuzz for emsdk 3.1.12 #2286

Merged
merged 9 commits into from Oct 20, 2022

Conversation

jeromelaban
Copy link
Contributor

@jeromelaban jeromelaban commented Oct 12, 2022

Description of Change

Adds explicit support for multi-threaded and SIMD combinations.

Bugs Fixed

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

mattleibow
mattleibow previously approved these changes Oct 12, 2022
@mattleibow
Copy link
Contributor

Do all these changes affect both libSkiaSharp and libHarfBuzzSharp?

I can't recall if this did both.

@jeromelaban
Copy link
Contributor Author

It looks like it does not, I'll make the change there as well.

@jeromelaban jeromelaban marked this pull request as draft October 12, 2022 12:59
@mattleibow
Copy link
Contributor

In a separate PR I'll try get wasm tests to run in all these combos.

@jeromelaban jeromelaban changed the title feat(wasm): Add mt and mt+simd for emsdk 3.1.12 feat(wasm): Add mt and mt+simd, fix harfbuzz for emsdk 3.1.12 Oct 12, 2022
@jeromelaban jeromelaban marked this pull request as ready for review October 13, 2022 12:26
@VahidN
Copy link

VahidN commented Dec 28, 2022

Sorry to ask it here. Are you using the last harfbuzz (V 6x)?

@drdmohssine
Copy link

I'm still getting the error:
--shared-memory is disallowed by libskia.SkOpts.o because it was not compiled with 'atomics' or 'bulk-memory' features.
is there any fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants