Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ToRect extension method extension #2392

Merged
merged 4 commits into from Jun 21, 2023
Merged

Fixed ToRect extension method extension #2392

merged 4 commits into from Jun 21, 2023

Conversation

niza93
Copy link
Contributor

@niza93 niza93 commented Feb 17, 2023

Description of Change

Changed ToRect method behavior

Bugs Fixed

API Changes

None.

Behavioral Changes

Fixed SKRect to Rect conversion

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@niza93
Copy link
Contributor Author

niza93 commented Feb 17, 2023

Well, some tests failed. What have I do next? @migueldeicaza need help. My change touches only WPF Extensions

@niza93
Copy link
Contributor Author

niza93 commented May 15, 2023

@dotnet-policy-service agree

@mattleibow mattleibow enabled auto-merge (squash) June 21, 2023 09:58
@mattleibow mattleibow merged commit 7bd1cc8 into mono:main Jun 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SKRect to WPF Rect is incorrect
2 participants