Update google/skia to milestone 115 #2547
Merged
+5,808
−5,011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
force-pushed
the
dev/update-skia-2
branch
2 times, most recently
from
7e44373
to
a44302b
Compare
mattleibow
force-pushed
the
dev/update-skia-2
branch
from
e6891d7
to
bc72543
Compare
This was a large set of changes, both to the code as well as to new requirements. The changes included: - Updated skia - Updated depot_tools (and this also needed changes - Added/chnaged/removed C++ types - Re-generated C# pinvokes - Minimum OS versions changed: - Android: 21 (v5.0) - macOS: 10.13 (High Sierra) - Tizen: 6.0 - tvOS: 11.0 - Debiam: 10 (Buster) - Updated macOS build agent to macOS 13 with Xcode 14.3.1 - Updated the Android NDK to r25c - Updated Tizen Studio to 5.1 - Ninja is now a required dependency and not included in depot_tools - Python is now used to run ninja instead of ninja run directly
The previous version was using i386
- Duplicate check in the Condition - `USE_WEBGL2=1` is now required
There are several large changes here, some are: - New color types - New encoder options - New sampling/filtering options - SKMatrix is totally new - Previously it was a limited class - Now it is a fully featured struct - Current implementation just wraps Matrix4x4 from System.Numerics - SKRuntimeEffect is redesigned - Similar API, but far more powerful - Granular shader/color filter creation - Improved uniforms/children API - Comes with a builder - SKFont is now a preferred API - Font APIs on SKPaint are all deprecated and will be removed - SKDrawable now has ApproximateBytesUsed - Added interop with the System.Numerics APIs - Removed types are: - SK3dView (this is now all available in the 4x4 matrix SKMatrix44) - SKMask - SKXamlWriter & SKXmlStreamWriter
mattleibow
force-pushed
the
dev/update-skia-2
branch
from
7aac514
to
16bfc8e
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR is the main set of changes to update to the latest "stable" chrome milestone:
115There are going to be several major breaking changes in this PR, but we will re-evaluate them all again once we are fully operational. The #2544 issue will track that part. Any APIs that are still needed and are within reason will be added in that work. This PR is going to aim for the most up-to-date and the as-clean-as-possible change.
Bugs Fixed
API Changes
This was a large set of changes, both to the code as well as to new requirements. The changes included:
Minimum Versions Changes:
Tooling Changes:
Code Changes:
SKColorTypeSKJpegEncoderOptions,SKPngEncoderOptions,SKWebpEncoderOptions)SKSamplingOptionsinstead ofSKFilterQuality)SKMatrix44is totally newSKRuntimeEffectis redesignedSKFontis now a preferred APISKPaintare all deprecated and will be removedSKDrawablenow hasGetApproximateBytesUsed()which can be overriddenSK3dView(this is now all available in the 4x4 matrixSKMatrix44)SKMaskSKXamlWriter&SKXmlStreamWriter(this was only used by SVG-related things and really just wrapped a stream)Behavioral Changes
Several changes TBD.
Required skia PR
None.
PR Checklist
Updated documentation(this will be in a separate PR after another API review)