Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(skxamlcanvas): [Wasm] Don't fail when the canvas can't be found #2563

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix(skxamlcanvas): [Wasm] Don't fail when the canvas can't be found #2563

merged 1 commit into from
Aug 18, 2023

Conversation

jeromelaban
Copy link
Contributor

Description of Change

Fixes possible exception when an SKXamlCanvas has been removed from the tree.

Bugs Fixed

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow added backport/release/2.x Backport this PR to release/2.x backport/release/2.88.4-preview Backport this PR to release/2.88.4-preview labels Aug 18, 2023
@mattleibow mattleibow merged commit 7f9951d into mono:main Aug 18, 2023
4 checks passed
@github-actions github-actions bot mentioned this pull request Aug 18, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Aug 18, 2023
@jeromelaban @github-actions
fix(skxamlcanvas): [Wasm] Don't fail when the canvas can't be found (#…
4d770af 
…2563)

(cherry picked from commit 7f9951d)
github-actions bot pushed a commit that referenced this pull request Aug 18, 2023
@jeromelaban @github-actions
fix(skxamlcanvas): [Wasm] Don't fail when the canvas can't be found (#…
9a47e09 
…2563)

(cherry picked from commit 7f9951d)
@github-actions github-actions bot mentioned this pull request Aug 18, 2023
Merged
mattleibow pushed a commit that referenced this pull request Aug 19, 2023
@github-actions @jeromelaban
fix(skxamlcanvas): [Wasm] Don't fail when the canvas can't be found (#…
9c67d83 
…2563) (#2565)

(cherry picked from commit 7f9951d)

Co-authored-by: Jérôme Laban <jerome.laban@nventive.com>
mattleibow pushed a commit that referenced this pull request Aug 19, 2023
@github-actions @jeromelaban
fix(skxamlcanvas): [Wasm] Don't fail when the canvas can't be found (#…
83ef108 
…2563) (#2564)

(cherry picked from commit 7f9951d)

Co-authored-by: Jérôme Laban <jerome.laban@nventive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattleibow mattleibow mattleibow approved these changes

Assignees
No one assigned
Labels
backport/release/2.x Backport this PR to release/2.x backport/release/2.88.4-preview Backport this PR to release/2.88.4-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeromelaban @mattleibow