Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unused arm64e architecture #2587

Merged
merged 1 commit into from Aug 28, 2023
Merged

Remove the unused arm64e architecture #2587

merged 1 commit into from Aug 28, 2023

Conversation

mattleibow
Copy link
Contributor

Description of Change

Apple doesn't allow submissions with that architecture. In this PR I will just comment it out and when it is ready for use I will add it back.

Bugs Fixed

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow added the backport/release/2.x Backport this PR to release/2.x label Aug 28, 2023
@mattleibow mattleibow merged commit 4d5c011 into main Aug 28, 2023
2 of 3 checks passed
@mattleibow mattleibow deleted the dev/remove-arm64e branch August 28, 2023 16:15
@github-actions github-actions bot mentioned this pull request Aug 28, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Aug 28, 2023
@mattleibow @github-actions
Remove the unused arm64e architecture (#2587)
59c3596 
Fixes #2584

(cherry picked from commit 4d5c011)
mattleibow added a commit that referenced this pull request Aug 29, 2023
@github-actions @mattleibow
Remove the unused arm64e architecture (#2587) (#2590)
bf2d7b2 
Fixes #2584

(cherry picked from commit 4d5c011)

Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/release/2.x Backport this PR to release/2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Unable to publish Xamarin iOS app to App Store with SkiaSharp with 2.88.4 or 2.88.5
1 participant
@mattleibow