Provide allocate-less overloads of methods in SKTextBlobBuilder #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why aren't you changing SKRunBuffer to a readonly struct? |
|
@Gillibald Avoiding breaking changes |
|
This can be a breaking change for V3 |
|
This sort of came to me #2775 Let me know if this is useful and leave comments/suggestions. |
|
Thanks for this PR. Closing this in favour of #2775 Since this API will be 3.0+ and the whole way the build works is different, the current API was mostly wrong. Hopefully the 3.x APIs are better to use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Uno Platform, we are using
AllocatePositionedRun, which in some scenarios can be problematic as it's allocating and it's in a hot path. See for example this is a case where this was responsible for 11.3% of all allocations.The idea here is to introduce a new API that won't allocate
SKPositionedRunBufferand instead give us theSpans that we need right away. I have made the same change to APIs other thanAllocatePositionedRunfor parity.