Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

None of the raster views should try allocate 0x0 memory. Fixes #759 #761

Merged
merged 1 commit into from Jun 20, 2019

Conversation

mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Jan 16, 2019

In some cases, a view dimension may be < 1, thus the allocation for 0 bytes of memory is not actually possible.

Fixes #759

VS bug #770231, VS bug #934149

@mikekinsman

This comment has been minimized.

@mikekinsman

This comment has been minimized.

@mikekinsman

This comment has been minimized.

@mikekinsman

This comment has been minimized.

@mikekinsman

This comment has been minimized.

@mikekinsman

This comment has been minimized.

@mikekinsman

This comment has been minimized.

@mikekinsman

This comment has been minimized.

@mikekinsman

This comment has been minimized.

@mikekinsman

This comment has been minimized.

@mikekinsman

This comment has been minimized.

@mikekinsman

This comment has been minimized.

@mikekinsman
Copy link
Contributor

OPS Build status updates of commit 81a44ed:

🕙 Preparing: average preparing time is 2 min(s) 1 sec(s)

@mikekinsman
Copy link
Contributor

OPS Build status updates of commit 81a44ed:

🕙 Incremental building: average incremental building time is 19 sec(s)

@mikekinsman

This comment has been minimized.

@mattleibow mattleibow merged commit 37336c3 into master Jun 20, 2019
@mattleibow mattleibow deleted the dev/fix-759 branch June 20, 2019 23:56
@mattleibow mattleibow added this to Done in v1.68.1 Nov 21, 2019
@mattleibow mattleibow added this to the v1.68.1 milestone Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v1.68.1
  
Done
Development

Successfully merging this pull request may close these issues.

[BUG] iOS OutOfMemory crash when SKCanvasView height or width less than 1
2 participants