Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentationEnumerator.cs: Declare iface and ifaceMethod correctly to #464

Merged
merged 1 commit into from Feb 11, 2020

Conversation

eclipseo
Copy link
Contributor

@eclipseo eclipseo commented Feb 3, 2020

fix NRE

Using TypeReference and MethodReference instead of var to declare them.

Fix #462

Signed-off-by: Robert-André Mauchin zebob.m@gmail.com

@eclipseo
Copy link
Contributor Author

eclipseo commented Feb 3, 2020

@joelmartinez Would you look at this simple patch, it fixes the NRE I was describing in mono/mono#16399 ?

fix NRE

Using TypeReference and MethodReference instead of var to declare them.

Fix mono#462

Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
Copy link
Member

@joelmartinez joelmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@joelmartinez joelmartinez merged commit ce05582 into mono:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants