Object: Fix ToggleRef disposing when we're being finalized #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not try to dispose our ToggleRef when Dispose(bool) has been called by the finalizer, because we should not reference any managed objects. Set and check the disposed flag inside of Dispose(bool) so that it's also done when the object is finalized. Also clear up a confusion between a local ToggleRef variable in Dispose and the ToggleRef member field.
|
Sorry this sat so long. Was this fixing an issue you had seen with your porting work? I think in order to avoid leaks, the ToggleRef class will need a Finalizer which does the native unref. |
|
I think was fixing a crash or an exception when exiting Banshee, but now I can't reproduce the problem. In any case, feel free to ignore this patch for now and do things differently if you wish. I'll ping this issue again if the problem comes back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not try to dispose our ToggleRef when Dispose(bool) has been
called by the finalizer, because we should not reference any managed
objects.
Set and check the disposed flag inside of Dispose(bool) so that it's
also done when the object is finalized.
Also clear up a confusion between a local ToggleRef variable in Dispose
and the ToggleRef member field.
A close inspection is needed on this one, to double-check that I'm not introducing any leak...