Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception on list-update and update #22

Open
diva opened this issue Jan 2, 2015 · 3 comments
Open

Exception on list-update and update #22

diva opened this issue Jan 2, 2015 · 3 comments

Comments

@diva
Copy link
Contributor

diva commented Jan 2, 2015

mautil always crashes when looking for updates:
$ ../../mono-addins/mono-addins/bin/mautil.exe -p . -reg F:/dev/registry list-update
Looking for updates...
Available add-in updates:
System.NullReferenceException: Object reference not set to an instance of an object.
at Mono.Addins.Setup.SetupTool.IsHidden(Addin ainfo) in F:\dev\mono-addins\mono-addins\Mono.Addins.Setup\Mono.Addins.Setup\SetupTool.cs:line 291
at Mono.Addins.Setup.SetupTool.ListUpdates(String[] args) in F:\dev\mono-addins\mono-addins\Mono.Addins.Setup\Mono.Addins.Setup\SetupTool.cs:line 357
at Mono.Addins.Setup.SetupTool.Run(String[] args) in F:\dev\mono-addins\mono-addins\Mono.Addins.Setup\Mono.Addins.Setup\SetupTool.cs:line 149
at mautil.MainClass.Main(String[] args) in F:\dev\mono-addins\mono-addins\mautil\Main.cs:line 110

I think I know why. In both SetupTool.cs ListUpdates(...) and SetupTool.cs Update(...) you have:
Addin sinfo = registry.GetAddin (addin.Addin.Id);

But addin.Addin.Id returns the full Id with the version number, so things like MyAddin,0.8.1.0.1

I believe you need to search for LocalId instead, so
Addin sinfo = registry.GetAddin (addin.Addin.LocalId);

I tried it and it fixed the issue. Since it's so simple to fix, I'm not sending up a pull request.

nebadon2025 pushed a commit to nebadon2025/opensimulator that referenced this issue Jan 2, 2015
@DavidKarlas
Copy link
Member

I kinda hope this doesn't get fixed... You forget about it... And in few months you update from upstream and forget this patch... Karma is bitch...

@diva
Copy link
Contributor Author

diva commented Jan 2, 2015

Too early in the year to even acknowledge the existence of sarcasm, I'm afraid... :-)
Try again, if this issue affects you too.

nebadon2025 pushed a commit to nebadon2025/opensimulator that referenced this issue Jan 2, 2015
…nd since these commits show up in that issue report, I thought I'd say 'hi' to the zealous Xamarin developer who seems to be eager to get pull requests. Not yet, my friend, not until I fix all the bugs that stand in my way, now that I'm using mautil :-)
@DavidKarlas
Copy link
Member

Internet is full of ******** people... It's hard to detect sarcasm really... Nice to see you are not one of them ;)

diva added a commit to diva/mono-addins that referenced this issue Jan 2, 2015
Therzok added a commit that referenced this issue Nov 22, 2019
Fixes the bug described in issue #22.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants