Handle array types correctly in ReviewLinqMethodRule. FIx bnc664556

* ReviewLinqMethodRule.cs: Handle array types correctly
* Test/ReviewLinqMethodTest.cs: Test case for above. Provided by Antoine
Vandecreme  <ant.vand@gmail.com>

gendarme/AUTHORS

@@ -16,7 +16,7 @@ Andres G. Aragoneses <aaragoneses@novell.com>
 Peter Johanson  <peter@peterjohanson.com>
 Jesse Jones  <jesjones@mindspring.com>
 Rolf Bjarne Kvinge <RKvinge@novell.com>
-Antoine Vandecreme  <avandecreme@sopragroup.com>
+Antoine Vandecreme  <ant.vand@gmail.com>
 Julien Hoarau  <madgnome@gmail.com>
 N Lum  <nol888@gmail.com>
 Nicholas Rioux  <nickr500@gmail.com>

gendarme/rules/Gendarme.Rules.Performance/ReviewLinqMethodRule.cs

@@ -124,7 +124,8 @@ private void CheckForCountProperty (TypeReference type, MethodDefinition method,
 				Log.WriteLine (this, "{0:X4} {1}", ins.Offset, message);
 				Runner.Report (method, ins, Severity.Medium, Confidence.High, message);
 
-			} else if (HasMethod (type, LengthProperty)) {
+			} else if (type.IsArray || HasMethod (type, LengthProperty)) {
+				// note: arrays [] always have a Length property but resolving arrays return the element type
 				string message = "Use the Length property instead of the Count () method.";
 				Log.WriteLine (this, "{0:X4} {1}", ins.Offset, message);
 				Runner.Report (method, ins, Severity.Medium, Confidence.High, message);

gendarme/rules/Gendarme.Rules.Performance/Test/ReviewLinqMethodTest.cs

@@ -293,5 +293,18 @@ public void Cases ()
 
 			AssertRuleSuccess<Bug656790> ("CanExecute");
 		}
+
+		class Bug664556 {
+			public int DoSomething (Bug664556 [] ic)
+			{
+				return ic.Count ();
+			}
+		}
+
+		[Test]
+		public void Array ()
+		{
+			AssertRuleFailure<Bug664556> ("DoSomething", 1);
+		}
 	}
 }