Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Work around DNS problem on the build hosts
- Loading branch information
1 parent
ed2d8f0
commit c86473c
Showing
1 changed file
with
9 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c86473c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be an Assert.Ignore() call (or Inconclusive) instead of just return?
c86473c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. I've seen a few spots in the test code base where a return is used when Assert.Ignore() would be better. Inconclusive isn't available in the NUnit version Mono uses AFAIK.
c86473c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there were quite a lot of tests that did this, I corrected them so test results aren't skewed: #910