-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect float return on x86 results in NaN value #20458
Comments
Could you run with MONO_VERBOSE_METHOD=GetBadFloatReturn on windows and attach the output ? |
Note
|
Hmm, let me see. That was latest Mono I downloaded and it looks to run correctly... |
Here is the invalid output from our older Mono in Unity (5.11.0). It seems this may already be fixed usptream.
|
I am bisecting Mono now. Will post details shortly... |
This was fixed after 5.12: 5.14.0.78 -> good |
My guess is this was fixed in the float32 optimization PRs. |
Could you run the 'good' version with -O=-inline ? |
Version:
"c:\Program Files (x86)\Mono\bin\mono.exe" -O=-inline D:\dev\ConsoleApp1\ConsoleApp1\bin\Release\ConsoleApp1.exe
|
So does it fail when run with -O=-inline ? |
No. It passes with newer version no matter the optimization settings. |
Weird, I don't really remember anything that would have fixed this. |
Can this be closed ? |
Steps to Reproduce
Current Behavior
Expected Behavior
On which platforms did you notice this
[ ] macOS
[ ] Linux
[X ] Windows
Version Used:
5.11.0
The text was updated successfully, but these errors were encountered: