New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[corlib] Bring back String.Concat with __arglist #10452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorBo
force-pushed
the
add-string-concat
branch
from
September 3, 2018 17:30
66a07c9
to
c88e843
Compare
Test case? |
@jaykrell Added! |
akoeplinger
approved these changes
Sep 3, 2018
@monojenkins backport 2018-08 |
@monojenkins backport 2018-06 |
@monojenkins backport 2018-04 |
This was referenced Sep 4, 2018
@monojenkins commit apidiff |
monojenkins
added a commit
to mono/api-snapshot
that referenced
this pull request
Sep 4, 2018
marek-safar
approved these changes
Sep 4, 2018
akoeplinger
pushed a commit
that referenced
this pull request
Sep 4, 2018
Backport of #10452. Fixes #9996 Tested repro project from the link on a local PostgresSQL server and EntityFramework packages. See https://github.com/aspnet/EntityFramework6/blob/master/src/EntityFramework/Core/Objects/ELinq/MethodCallTranslator.cs#L1482-L1497
akoeplinger
pushed a commit
that referenced
this pull request
Sep 4, 2018
Backport of #10452. Fixes #9996 Tested repro project from the link on a local PostgresSQL server and EntityFramework packages. See https://github.com/aspnet/EntityFramework6/blob/master/src/EntityFramework/Core/Objects/ELinq/MethodCallTranslator.cs#L1482-L1497
akoeplinger
pushed a commit
that referenced
this pull request
Sep 4, 2018
Backport of #10452. Fixes #9996 Tested repro project from the link on a local PostgresSQL server and EntityFramework packages. See https://github.com/aspnet/EntityFramework6/blob/master/src/EntityFramework/Core/Objects/ELinq/MethodCallTranslator.cs#L1482-L1497
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9996
Tested repro project from the link on a local PostgresSQL server and EntityFramework packages.
See https://github.com/aspnet/EntityFramework6/blob/master/src/EntityFramework/Core/Objects/ELinq/MethodCallTranslator.cs#L1482-L1497