[runtime] Avoid warning about missing icalls when AOTing. #10760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Fixed. |
vargaz
force-pushed
the
no-warn-missing
branch
2 times, most recently
from
2f3fa02
to
3d5900a
Compare
luhenry
suggested changes
Sep 24, 2018
mono/metadata/icall.c
Outdated
| @@ -8291,7 +8291,7 @@ no_icall_table (void) | |||
| * If the method is not found, warns and returns NULL. | |||
| */ | |||
| gpointer | |||
| mono_lookup_internal_call_full (MonoMethod *method, mono_bool *uses_handles) | |||
| mono_lookup_internal_call_full2 (MonoMethod *method, gboolean warn_on_missing, mono_bool *uses_handles) | |||
There was a problem hiding this comment.
Since mono_lookup_internal_call_full is now dead-code (it's not MONO_API and nothing else use it in the runtime AFAICT), why not simply adding the parameter to mono_lookup_internal_call_full?
|
It was in loader.h which is a public header. Is that just an oversight ? |
…ookup_internal_call_full () to icall-internals.h since its not a public api function. Fixes mono#10598.
vargaz
force-pushed
the
no-warn-missing
branch
from
3d5900a
to
1bcfe22
Compare
luhenry
approved these changes
Sep 25, 2018
|
@monojenkins backport 2018-10 |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…ookup_internal_call_full () to icall-internals.h (mono/mono#10760) since its not a public api function. Fixes mono/mono#10598. Commit migrated from mono/mono@1f6b738
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10598.