[corlib] Fixed test that failed intermittently #1114
Closed
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a race condition in the test, the #2 Assert() can be reached before e1 is assigned if the thread that handles e1 gets preempted by the scheduler (this is more likely on single-core systems). Adding a sleep before checking the values fixes this for now. Commit licensed under MIT/X11.
|
I don't like unreliable Sleep and fixed the issue differently. |
|
As long as it works I don't care :) |
AlexKnauth
pushed a commit
to AlexKnauth/mono
that referenced
this pull request
Nov 2, 2023
…ditor-support Incremental gc editor support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition in the test, the "#2" Assert() can be reached before e1 is assigned if the thread
that handles e1 gets preempted by the scheduler (this is more likely on single-core systems). Adding a sleep before checking the values fixes this for now.
@marek-safar can you verify this doesn't change the behavior of the test (you added it in b787868)?