Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Fixes wasm tools to run on desktop .net as well #11351

Merged
merged 2 commits into from Oct 25, 2018
Merged

[build] Fixes wasm tools to run on desktop .net as well #11351

merged 2 commits into from Oct 25, 2018

Conversation

marek-safar
Copy link
Member

@marek-safar marek-safar commented Oct 24, 2018 •
edited

Fixes #11326

@akoeplinger
Copy link
Member

Fails with:

make: *** No rule to make target '/mnt/jenkins/workspace/test-mono-pull-request-wasm/mcs/class/lib/wasm_tools/Mono.Cecil.dll', needed by 'Mono.Cecil.dll'.  Stop.
make: *** Waiting for unfinished jobs....

@kjpou1
Copy link
Contributor

kjpou1 commented Oct 25, 2018

Marek

Will this address: #11326 ?

@marek-safar
Copy link
Member Author

@kjpou1 yes a few others (just need to find them all)

@marek-safar
Copy link
Member Author

@monojenkins commit csproj

@akoeplinger akoeplinger merged commit 7ec5a9a into mono:master Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumpera kumpera kumpera approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@luhenry luhenry Awaiting requested review from luhenry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marek-safar @akoeplinger @kjpou1 @kumpera @monojenkins