Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] AOT work. #11444

Merged
merged 15 commits into from Nov 6, 2018
Merged

[wasm] AOT work. #11444

merged 15 commits into from Nov 6, 2018

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Oct 30, 2018

No description provided.

@vargaz vargaz requested a review from kumpera as a code owner October 30, 2018 03:30
@vargaz vargaz changed the title [aot] Remove unused got_offset arguments from a few functions. Fix a warning. NFC. [wasm] AOT work. Oct 30, 2018
@lewurm
Copy link
Contributor

lewurm commented Oct 30, 2018

looks good? why the do-not-merge label?

@vargaz
[llvmonly] Rework the handling of direct calls.
9960c5b 
Move the allocation of got offsets for calls to a separate pass after all methods have been compiled. This means
that got offsets do not need to be allocated for calls which can be turned into direct calls.
@vargaz
Copy link
Contributor Author

vargaz commented Nov 1, 2018

@monojenkins build failed

@vargaz
Copy link
Contributor Author

vargaz commented Nov 1, 2018

@monojenkins build failed

@vargaz
Copy link
Contributor Author

vargaz commented Nov 1, 2018

@monojenkins build failed

2 similar comments
@vargaz
Copy link
Contributor Author

vargaz commented Nov 1, 2018

@monojenkins build failed

@vargaz
Copy link
Contributor Author

vargaz commented Nov 2, 2018

@monojenkins build failed

@vargaz
Copy link
Contributor Author

vargaz commented Nov 3, 2018

@monojenkins build failed

1 similar comment
@vargaz
Copy link
Contributor Author

vargaz commented Nov 4, 2018

@monojenkins build failed

@vargaz
[runtime] Add a --enable-minimal=assert_messages option to remove ass…
ed19b6e 
…ertion messages, only file/line numbers are retained. Enable it for wasm.
@vargaz
Copy link
Contributor Author

vargaz commented Nov 4, 2018

@monojenkins build failed

@vargaz
Copy link
Contributor Author

vargaz commented Nov 5, 2018

@monojenkins commit apidiff

@vargaz
Copy link
Contributor Author

vargaz commented Nov 6, 2018

@monojenkins build failed

@luhenry
Copy link
Contributor

luhenry commented Nov 6, 2018

@monojenkins commit csproj

@luhenry
Copy link
Contributor

luhenry commented Nov 6, 2018

@vargaz why do we need ed19b6e?

@vargaz
Copy link
Contributor Author

vargaz commented Nov 6, 2018

It saves around 30k from the executable size.

@vargaz
Copy link
Contributor Author

vargaz commented Nov 6, 2018

@monojenkins build failed

@kumpera kumpera merged commit ce08c32 into mono:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewurm lewurm lewurm approved these changes

@marek-safar marek-safar marek-safar approved these changes

@kumpera kumpera Awaiting requested review from kumpera

@luhenry luhenry Awaiting requested review from luhenry

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vargaz @lewurm @luhenry @marek-safar @kumpera @monojenkins