Add missing elements to allow MVC5.2 site to run #1163

AerisG222 · 2014-07-16T00:26:15Z

In combination with PR874, this allowed my site to work after trying to upgrade to the latest MVC version

monoadmin · 2014-07-16T00:26:17Z

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

d0apga · 2014-08-16T05:14:21Z

in master branch, HttpContextWrapper.GetService still not implement?

monoadmin · 2014-08-20T10:34:48Z

Hello! I'm the new build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

marxin · 2014-09-23T21:51:33Z

Hello.

I've just tried to apply the patch and my MVC+NHibernate application works correctly. I was using a different branch from matthid's fork. I would like to see the pull request in trunk, is there any blocker?

Thanks.
Martin

knocte · 2014-09-26T17:31:05Z

@AerisG222 can you squash your commits into just one please?

AerisG222 · 2014-09-26T21:01:50Z

Happy to try, am not so proficient with git. By any chance do you have a
reference you can point me at to help squash easily?

Thanks,
Mike

@AerisG222 https://github.com/AerisG222 can you squash your commits into
just one please?

—
Reply to this email directly or view it on GitHub
#1163 (comment).

Therzok · 2014-09-26T21:11:23Z

Hey @AerisG222 !

Once you're on the more_mvc_fixes branch, you can do the following:

git rebase -i HEAD~6

While rebasing, on the first commit you made, to change the commit message you can write reword instead of pick. You can mark the others with fixup and they will be merged into the first.

Therzok · 2014-09-26T21:11:51Z

See more here.

AerisG222 · 2014-09-27T13:39:38Z

Thanks for the pointers, that was very helpful!

knocte · 2014-09-27T21:26:05Z

Mike, thanks for squashing them. Unfortunately I've just realised there are still nitpicks to fix regarding style, I'll point them now:

knocte · 2014-09-27T21:26:54Z

mcs/class/System.Web.Abstractions/System.Web/HttpContextWrapper.cs

 		public override object GetService (Type serviceType)
 		{
-			throw new NotImplementedException ();
+			return ((IServiceProvider)w).GetService(serviceType);


Space between GetService and (.

Therzok · 2014-09-28T13:34:21Z

Looks good on my end.

akoeplinger · 2014-09-28T16:21:38Z

The first commit by @chrisfcarroll is actually part of PR #874 and should be excluded here I think. I wonder why the other PR wasn't merged yet, it looks good from my POV.

martinjt · 2014-10-12T17:25:28Z

@knocte is there any hold up on getting this merged now that the changes you've suggested have been made?

knocte · 2014-10-12T19:26:40Z

I guess not, but I'm no maintainer. You need to bother @grendello I guess.

martinjt · 2014-10-13T18:50:16Z

@grendello what does one need to bribe you with to get a final review and merge on this? I have a nice single malt here?

martinjt · 2014-10-16T22:48:16Z

mcs/class/System.Web/System.Web.Security/MembershipPasswordAttribute.cs

+		private readonly string _minRequiredPasswordLengthError = "{0} must have at least {1} characters";
+		private readonly string _minNonAlphanumericCharactersError = "{0} must have at least {1} special characters";
+		private readonly string _passwordStrengthError = "{0} is weak";
+


Shouldn't need private here.

martinjt · 2014-10-16T22:51:47Z

@AerisG222 I'm going to try some unit tests for this, are you going to be able to review and accept them as a pull?

AerisG222 · 2014-10-16T23:04:08Z

I'm happy to review and will try to pull when there is something available.
though might look for help to make sure everything is pulled and wrapped
up nicely, as I've struggled with that before ;)

In all honesty, I've tried to move on to reworking my site to vnext as that
should be a much better platform to build from given the cross platform
focus. Granted, this is a ways away, but even with the patch we've been
commenting on, my site still hits an error on the webapi side. I
understand for others they won't have the luxury of upgrading, but
depending on your needs/interests, time might be better spent helping to
ensure that project has a quality experience on mono...

On Thu, Oct 16, 2014 at 6:51 PM, martinjt notifications@github.com wrote:

@AerisG222 https://github.com/AerisG222 I'm going to try some unit
tests for this, are you going to be able to review and accept them as a
pull?

—
Reply to this email directly or view it on GitHub
#1163 (comment).

martinjt · 2014-10-16T23:09:01Z

I'm having the same issue with WebAPI, I think I've got a handle on all the things that need implementing. I've submitted a pull around encryption, I think there are 2 more to come, on is the HttpTaskAsyncHandler, but I can't remember what the other one is. After that, 5.2 (WebAPI and MVC) should "work", it's then a bug fix exercise.

Could you fix the "private" issue I commented on? and squash like you did with the last one? Also, any help with writing unit tests for this would be helpful.

AerisG222 · 2014-10-16T23:16:23Z

Yea, let me try to find some time this weekend to fix the private issue you
identified, and will re-squash. I'll try to have a look at some unit tests
but timing is difficult...

On Thu, Oct 16, 2014 at 7:09 PM, martinjt notifications@github.com wrote:

I'm having the same issue with WebAPI, I think I've got a handle on all
the things that need implementing. I've submitted a pull around encryption,
I think there are 2 more to come, on is the HttpTaskAsyncHandler, but I
can't remember what the other one is. After that, 5.2 (WebAPI and MVC)
should "work", it's then a bug fix exercise.

Could you fix the "private" issue I commented on? and squash like you did
with the last one? Also, any help with writing unit tests for this would be
helpful.

—
Reply to this email directly or view it on GitHub
#1163 (comment).

chrisfcarroll · 2014-10-18T10:26:10Z

You were waiting for #874 ? I did the (hopefully) final correction and rebased.

martinjt · 2014-10-18T11:16:41Z

This all looks fine to me now. We just need someone to review and merge.

I am planning on putting a full list of the Pulls needed for the aspnetwebstack features to work, then we can try and get someone to review & merge them all at once.

If we can't get them merged, I'm going to create a fork so we can collate a work aspnetwebstack piece.

AerisG222 · 2014-10-18T13:33:27Z

I've cleaned up the 'private' issue, and squashed.

kumpera · 2014-10-18T14:26:47Z

@grendello what do you think? can we merge this one?

migueldeicaza · 2014-10-20T13:57:39Z

Hey guys,

This code contains some obvious code that was lifted from .NET (the MembershipValidator).

AerisG222 · 2014-10-25T19:39:05Z

Apologies again for this, I have removed the file that I did not author.

martinjt · 2014-10-25T19:44:27Z

...tem.ComponentModel.DataAnnotations/net_4_5_System.ComponentModel.DataAnnotations.dll.sources

@@ -7,6 +7,7 @@ System.ComponentModel.DataAnnotations/EmailAddressAttribute.cs
 System.ComponentModel.DataAnnotations/PhoneAttribute.cs
 System.ComponentModel.DataAnnotations/FileExtensionsAttribute.cs
 System.ComponentModel.DataAnnotations/CompareAttribute.cs
+System.ComponentModel.DataAnnotations/UrlAttribute.cs


This isn't required, it's defined in the base file

migueldeicaza · 2014-11-02T00:36:46Z

Thanks for removing the third-party code and squashing the commits.

Add missing elements to allow MVC5.2 site to run

liuxm6 · 2017-02-12T08:58:57Z

mvc 5.2.3 on mono 4.8.0 error
The view found at '~/Views/Home/Index.cshtml' was not created.

Add missing elements to allow MVC5.2 site to run Commit migrated from mono/mono@e4d8f21

Fix warning crash

knocte reviewed Sep 27, 2014
View reviewed changes

kumpera force-pushed the master branch from 6284627 to 727f8fe Compare October 15, 2014 18:32

martinjt reviewed Oct 16, 2014
View reviewed changes

martinjt reviewed Oct 25, 2014
View reviewed changes

Add/update missing bits in order to support MVC5.2.

d35449e

migueldeicaza added a commit that referenced this pull request Nov 2, 2014

Merge pull request #1163 from AerisG222/more_mvc_fixes

e4d8f21

Add missing elements to allow MVC5.2 site to run

migueldeicaza merged commit e4d8f21 into mono:master Nov 2, 2014

AerisG222 deleted the more_mvc_fixes branch November 2, 2014 00:45

pdonald mentioned this pull request Dec 22, 2014

Fix ASP.NET TechEmpower/FrameworkBenchmarks#1287

Merged

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022

Merge pull request mono/mono#1163 from AerisG222/more_mvc_fixes

55111e3

Add missing elements to allow MVC5.2 site to run Commit migrated from mono/mono@e4d8f21

AlexKnauth pushed a commit to AlexKnauth/mono that referenced this pull request Nov 2, 2023

Merge pull request mono#1163 from Unity-Technologies/fix-warning-crash

acf432a

Fix warning crash

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing elements to allow MVC5.2 site to run #1163

Add missing elements to allow MVC5.2 site to run #1163

AerisG222 commented Jul 16, 2014

monoadmin commented Jul 16, 2014

d0apga commented Aug 16, 2014

monoadmin commented Aug 20, 2014

marxin commented Sep 23, 2014

knocte commented Sep 26, 2014

AerisG222 commented Sep 26, 2014

Therzok commented Sep 26, 2014

Therzok commented Sep 26, 2014

AerisG222 commented Sep 27, 2014

knocte commented Sep 27, 2014

knocte Sep 27, 2014

Therzok commented Sep 28, 2014

akoeplinger commented Sep 28, 2014

martinjt commented Oct 12, 2014

knocte commented Oct 12, 2014

martinjt commented Oct 13, 2014

martinjt Oct 16, 2014

martinjt commented Oct 16, 2014

AerisG222 commented Oct 16, 2014

martinjt commented Oct 16, 2014

AerisG222 commented Oct 16, 2014

chrisfcarroll commented Oct 18, 2014

martinjt commented Oct 18, 2014

AerisG222 commented Oct 18, 2014

kumpera commented Oct 18, 2014

migueldeicaza commented Oct 20, 2014

AerisG222 commented Oct 25, 2014

martinjt Oct 25, 2014

migueldeicaza commented Nov 2, 2014

liuxm6 commented Feb 12, 2017

Add missing elements to allow MVC5.2 site to run #1163

Add missing elements to allow MVC5.2 site to run #1163

Conversation

AerisG222 commented Jul 16, 2014

monoadmin commented Jul 16, 2014

d0apga commented Aug 16, 2014

monoadmin commented Aug 20, 2014

marxin commented Sep 23, 2014

knocte commented Sep 26, 2014

AerisG222 commented Sep 26, 2014

Therzok commented Sep 26, 2014

Therzok commented Sep 26, 2014

AerisG222 commented Sep 27, 2014

knocte commented Sep 27, 2014

knocte Sep 27, 2014

Choose a reason for hiding this comment

Therzok commented Sep 28, 2014

akoeplinger commented Sep 28, 2014

martinjt commented Oct 12, 2014

knocte commented Oct 12, 2014

martinjt commented Oct 13, 2014

martinjt Oct 16, 2014

Choose a reason for hiding this comment

martinjt commented Oct 16, 2014

AerisG222 commented Oct 16, 2014

martinjt commented Oct 16, 2014

AerisG222 commented Oct 16, 2014

chrisfcarroll commented Oct 18, 2014

martinjt commented Oct 18, 2014

AerisG222 commented Oct 18, 2014

kumpera commented Oct 18, 2014

migueldeicaza commented Oct 20, 2014

AerisG222 commented Oct 25, 2014

martinjt Oct 25, 2014

Choose a reason for hiding this comment

migueldeicaza commented Nov 2, 2014

liuxm6 commented Feb 12, 2017