Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[loader] ignore 'internalcall' impl attribute on 'abstract' methods #11755

Merged
merged 1 commit into from Nov 22, 2018
Merged

[loader] ignore 'internalcall' impl attribute on 'abstract' methods #11755

merged 1 commit into from Nov 22, 2018

Conversation

lambdageek
Copy link
Member

Otherwise we emit a noisy warning when doing a lookup of the method.

Fixes #11479

@lambdageek
[loader] ignore 'internalcall' impl attribute on 'abstract' methods
dbb7b98 
Otherwise we emit a noisy warning when doing a lookup of the method.

Fixes mono#11479
@lambdageek
Copy link
Member Author

@vargaz this feels like a hack, but we check for METHOD_IMPL_ATTRIBUTE_INTERNAL_CALL all over the place and I wasn't sure how to ignore it consistently on abstract methods otherwise.

@marek-safar marek-safar merged commit 9ac5844 into mono:master Nov 22, 2018
@marek-safar
Copy link
Member

@monojenkins backport 2018-10

@marek-safar
Copy link
Member

@monojenkins backport 2018-08

This was referenced Nov 23, 2018
Merged
Merged
@lambdageek lambdageek deleted the fix-gh-11479 branch February 23, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vargaz vargaz vargaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lambdageek @marek-safar @vargaz