[corlib]: Bring Random from CoreFX and add RandomNumberGenerator.Fill(Span<byte>).
#11797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add tests for Random as well so we know it works as expected |
|
I believe the only test that we did not enable was |
marek-safar
approved these changes
Nov 27, 2018
|
@monojenkins commit csproj |
|
@baulig there are few conflicts to resolve |
|
@monojenkins commit apidiff |
baulig
force-pushed
the
work-corefx-random
branch
from
13efc90
to
ce6469e
Compare
|
@baulig please don't use "commit apidiff" until the PR is about to be merged, it creates conflicts with other PRs otherwise. |
…ill(Span<byte>)`.
baulig
force-pushed
the
work-corefx-random
branch
from
ce6469e
to
703f313
Compare
|
@monojenkins build failed |
|
@monojenkins commit apidiff and csproj |
monojenkins
added a commit
to mono/api-snapshot
that referenced
this pull request
Nov 30, 2018
alexischr
pushed a commit
to alexischr/mono
that referenced
this pull request
Dec 5, 2018
…ill(Span<byte>)`. (mono#11797) This adds some `Span<byte>` overloads to `Random` and `RandomNumberGenerator`. Part of mono#7737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some
Span<byte>overloads toRandomandRandomNumberGenerator.Part of #7737