[coop] Drop support for MONO_ENABLE_BLOCKING_TRANSITION env var #12270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was never documented and it is not as useful now with a matured hybrid suspend. If MONO_ENABLE_BLOCKING_TRANSITION set, and mono is otherwise configured to use preemptive suspend, the thread state machinery would perform RUNNING->BLOCKING transitions (ie: MONO_ENTER_GC_SAFE and friends would be more than no-ops), but still preemptively suspend every thread. This was useful for testing the thread transitions separately from the coop suspend details.
BrzVlad
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was never documented and it is not as useful now with a matured hybrid
suspend.
If
MONO_ENABLE_BLOCKING_TRANSITIONis set, and mono is otherwise configured to usepreemptive suspend, the thread state machinery would perform RUNNING->BLOCKING
transitions (ie:
MONO_ENTER_GC_SAFEand friends would be more than no-ops), butstill preemptively suspend every thread. This was useful for testing the
thread transitions separately from the coop suspend details.