[System.Private.CoreLib] Initial build pass #12450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marek-safar
requested review from
akoeplinger,
lambdageek and
vargaz
as code owners
vargaz
reviewed
Jan 16, 2019
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Compile Include="temp\*.cs" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
yes, will populate that with not migrated files in follow up change
vargaz
reviewed
Jan 16, 2019
| RuntimeThread (Thread t) { thread = t; } | ||
|
|
||
| private Thread AsThread() | ||
| { |
There was a problem hiding this comment.
Shouldn't these files use the mono coding conventions ?
There was a problem hiding this comment.
I am not sure, I suspect some changes will eventually migrate to shared which means coreclr coding convention, do we want to do the conversion at that point?
lambdageek
reviewed
Jan 16, 2019
marek-safar
force-pushed
the
build-fixes
branch
from
04aa0e4
to
01aaa55
Compare
lambdageek
approved these changes
Jan 17, 2019
|
@monojenkins commit apidiff |
monojenkins
added a commit
to mono/api-snapshot
that referenced
this pull request
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.