Minor changes of pull 1281 #1282
Conversation
|
Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
| if (transform == null) | ||
| throw new ArgumentNullException ("transform"); | ||
| if (blockSize <= 0) | ||
| throw new ArgumentOutOfRangeException ("blockSize"); |
There was a problem hiding this comment.
Those helped me alot find a bug with HashAlgorithm that was using a Null Key, it was passing it to a BlockProcessor and never noticed it...
Add missing argument validations and set disposed flag to true once Dispose is called
|
Reverted. The changes makes test fails and our test must behave identically to what MS .NET does on Windows. IOW if MS throws an NRE we will throw an NRE, not an ANE. |
|
Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
|
My fault, i added the change by mistake to 15659482046963f2731be4e29e50784ddc661939 Also, i can't edit this commit since it is marked as merged. |
|
I made a PR only for the CryptoTools.cs BlockProcessor #1325 HMAC.cs Dispose(bool) in master still have the line The check in ComputeHash (Stream inputStream) was not really needed, trying to use a null stream will still result in a NRE anyway. I rebased #1281 so it will not conflic anymore after the revert and removed the conflicting lines from the commit. Not sure if i should add them again in their own commit or PR ?? |
Add missing argument validations and set disposed flag to true once Dispose is called Commit migrated from mono/mono@f234e42
…-windows-abort Fix abort behavior on Windows
See #1281