Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime] Avoid putting non-virtual and non-static DIM methods into vtables, roslyn generates these for private property accessors. #13449

Merged
merged 1 commit into from Mar 18, 2019
Merged

[runtime] Avoid putting non-virtual and non-static DIM methods into vtables, roslyn generates these for private property accessors. #13449

merged 1 commit into from Mar 18, 2019

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Mar 13, 2019

Fixes part of #13374.

@vargaz
[runtime] Avoid putting non-virtual and non-static DIM methods into v…
74e7e0f 
…tables, roslyn generates these for private property accessors.

Fixes part of mono#13374.
@vargaz vargaz mentioned this pull request Mar 13, 2019
Closed
@vargaz
Copy link
Contributor Author

vargaz commented Mar 14, 2019

@monojenkins build failed

1 similar comment
@vargaz
Copy link
Contributor Author

vargaz commented Mar 14, 2019

@monojenkins build failed

@thaystg thaystg merged commit 5232408 into mono:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaystg thaystg thaystg approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek

@luhenry luhenry Awaiting requested review from luhenry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vargaz @thaystg