[2019-02] Do not use MAP_JIT by default (take 2) #14001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggled by Xamarin.Mac which needs it
monojenkins
requested review from
lateralusX,
lewurm,
luhenry,
marek-safar and
vargaz
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second version of this. Previously #13446 which had to be reverted due to Windows and WASM breakage.
Add stub Win32 and WASM implementations of
mono_setmmapjitDo not use MAP_JIT by default, instead make this something that is toggled by Xamarin.Mac which needs it.
Fixes regression from #13445
This is surfaced via a command line option, to not make this a strong API requirement on Xamarin.Mac requiring it. See companion patch:
https://gist.github.com/migueldeicaza/fef015421e260a1d1ba297c3ba7cd145
Backport of #13958.
/cc @marek-safar @lambdageek