[System.Core] Fixed wrong DST of TimeZoneInfo with floating date rules. #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| [Test] //Covers #26008 | ||
| public void DSTWithFloatingDateRule () | ||
| { |
There was a problem hiding this comment.
Indent is using spaces here.
Fixes #26008 We do not want (transition.DayOfWeek - first) % 7 to be negative. As (transition.DayOfWeek - first) cannot be lower than -7, adding 7 to it solves the issue.
esdrubal
force-pushed
the
tzifloatingrule
branch
from
d132294
to
e0278f8
Compare
marek-safar
added a commit
that referenced
this pull request
Jan 15, 2015
[System.Core] Fixed wrong DST of TimeZoneInfo with floating date rules.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
[System.Core] Fixed wrong DST of TimeZoneInfo with floating date rules. Commit migrated from mono/mono@bc6ea9d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #26008
We do not want (transition.DayOfWeek - first) % 7 to be negative.
As (transition.DayOfWeek - first) cannot be lower than -7, adding 7 to it solves the issue.