[System.ServiceModel] Fix timeout defaulting to 0 seconds #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -149,7 +160,7 @@ internal MetadataSet GetMetadataInternal (EndpointAddress address, MetadataExcha | |||
| var asClientChannel = proxy as IClientChannel; | |||
| if (asClientChannel == null) | |||
| throw new InvalidOperationException ("The channel factory must return an IClientChannel implementation"); | |||
| asClientChannel.OperationTimeout = OperationTimeout; | |||
| asClientChannel.OperationTimeout = this.OperationTimeout; | |||
alexanderkyte
force-pushed
the
webservice_27561
branch
from
510e64a
to
8d88614
Compare
|
build |
1 similar comment
|
build |
|
Well, I'm no expert on WCF, but this looks sensible to me. @migueldeicaza what do you think? |
|
build |
|
I'm seeing clean on x86/amd64 and on arm I see which is an intermittent failure that I've been seeing on most PRs on arm. |
| @@ -322,8 +321,19 @@ public void Dispose () | |||
| } | |||
| } | |||
|
|
|||
| [MonoTODO] | |||
| public TimeSpan OperationTimeout { get; set; } | |||
| TimeSpan? operation_timeout = null; | |||
There was a problem hiding this comment.
This should go to the top with all the other fields.
|
LGTM |
alexanderkyte
force-pushed
the
webservice_27561
branch
from
8d88614
to
e4d491c
Compare
|
Moved it up. |
alexrp
added a commit
that referenced
this pull request
May 15, 2015
[System.ServiceModel] Fix timeout defaulting to 0 seconds
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
[System.ServiceModel] Fix timeout defaulting to 0 seconds Commit migrated from mono/mono@1f8da92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.