[wasm][http] WasmHttpMessageHandler StreamingEnabled default to false #17328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kg
approved these changes
Oct 15, 2019
|
Yes, I will set up an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default
StreamingEnabledproperty of the WasmHttpMessageHandler to befalse.Due to the way that the javascript
FetchAPI works asynchronously the non asynchronous methods of the wrapped stream can not be used.There are some API's such as the
CsvHelperthat do not implement an async API.Setting the default implementation to false solves this issue as the read content is wrapped in a memory stream and is able to be used in those circumstances.
fixes #17343